Drop Neutral Colors collection from Alert and Card (#615)
#616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedrich-schindler
approved these changes
Mar 26, 2025
mbohal
approved these changes
Mar 26, 2025
adamkudrna
force-pushed
the
bc/drop-neutral-colors-alert-card
branch
from
dd7cddf to
c11898c
Compare
adamkudrna
force-pushed
the
feature/468-modal-colors
branch
2 times, most recently
from
abe61fc to
3028631
Compare
We found the Neutral Colors collection insufficiently flexible to use, so we are removing it from more complex components where its usage was unclear and confusing. Features: - New `--rui-Card__background-color` custom property has been introduced to define `Card`'s default background color. Breaking changes: - `Alert`: light and dark colors (Neutral Colors collection) have been dropped with no replacement. - `Card`: light color now corresponds to the default appearance. The dark color option has been dropped with no replacement. Migration: - `Alert`: pick another color from the Feedback Colors collection. - `Card`: remove `color="light"` to keep the default light appearance. If using `color="dark"`, pick another color from the Feedback Colors collection.
adamkudrna
force-pushed
the
bc/drop-neutral-colors-alert-card
branch
from
c11898c to
0bd3f27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found the Neutral Colors collection insufficiently flexible to use, so we are removing it from more complex components where its usage was unclear and confusing.
Features:
--rui-Card__background-colorcustom property has been introduced to defineCard's default background color.Breaking changes:
Alert: light and dark colors (Neutral Colors collection) have been dropped with no replacement.Card: light color now corresponds to the default appearance. The dark color option has been dropped with no replacement.Migration:
Alert: pick another color from the Feedback Colors collection.Card: removecolor="light"to keep the default light appearance. If usingcolor="dark", pick another color from the Feedback Colors collection.Closes #615.